Refactor CodeableConceptCdMapper#1136
Merged
MartinWheelerMT merged 6 commits intomainfrom Mar 5, 2025
Merged
Conversation
* Refactor `mapCodeableConceptForMedication` and `mapCodeableConceptToCd` to reduce code duplication. * Refactor `mapCodeableConceptToCdForAllergy` for readability
…ergy when a snomed code is not present.
…ither ACTIVE nor RESOLVED. * Remove unnecessary nesting in `findOriginalTextForAllergy` as the equals already handles case where it is not present.
…riginalTextForActiveAllergy` yields as the fallback method contains the exact same functionality.
…tional.empty() which so this is already implied. * Refactor method to functional style for code consistency
* Remove now unnecessary test
|
Looks good. All 33 mutations in this change were killed.
|
|
Bhavesh-Patel
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
mapCodeableConceptForMedicationandmapCodeableConceptToCdto reduce code duplication.mapCodeableConceptToCdForAllergyfor readability.findOriginalTextForAllergyas the equals already handles case where it is not present.Why
Improving code quality and readability, preparing for further work on NIAD-3304
Type of change
Please delete options that are not relevant.
Checklist: